Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for shard scoped foreign keys #15571

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add testing for shard scoped foreign keys #15571

merged 3 commits into from
Mar 29, 2024

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Mar 26, 2024 •
edited
Loading

Description

This PR adds testing for shard-scoped foreign keys. While making these changes we realised that for shard-scoped foreign keys, the foreign key columns have to be part of the sharding key, which automatically fails all the updates on those columns! 😿

So, we can currently only support DELETE RESTRICT and DELETE CASCADE style operations. This PR adds the infra for adding the tests for all the scenarios but skips all the ones that don't work for now. For the same reason, I haven't enabled fuzzer tests either for shard-scoped foreign keys because of the very limited number of queries that actually work.

Here are the tests that work as intended -

Screenshot 2024-03-27 at 11 49 20 AM

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
test: add testing for shard scoped foreign keys
fabd90b 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 26, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 26, 2024
@GuptaManan100
test: skip tests that don't work for now
5fed995 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Component: Query Serving Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 27, 2024
@GuptaManan100 GuptaManan100 marked this pull request as ready for review March 27, 2024 06:23
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@90c0057). Click here to learn what that means.
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15571   +/-   ##
=======================================
  Coverage        ?   65.78%           
=======================================
  Files           ?     1561           
  Lines           ?   194838           
  Branches        ?        0           
=======================================
  Hits            ?   128181           
  Misses          ?    66657           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100
test: fix comment to skip the test
89bc55a 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@deepthi deepthi self-requested a review March 29, 2024 05:02
@GuptaManan100 GuptaManan100 merged commit 6d88acd into vitessio:main Mar 29, 2024
102 checks passed
@GuptaManan100 GuptaManan100 deleted the fk-sharded-test branch March 29, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Testing
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @deepthi @harshit-gangal